Summary

Fixes the BOM consumer POM builder leaving ${...} property references unresolved when consumer POM flattening is disabled (the default).

Reported by Karl Heinz Marbaise during the 4.0.0-rc-6 vote.

Problem

DefaultConsumerPomBuilder.buildBomWithoutFlatten() used getRawModel() (no interpolation), but then transformBom() strips both the parent and properties sections. The result is a consumer POM with dangling property references that no consumer can resolve.

Example — a BOM with ${junit.version} defined in its parent produced this consumer POM:

<!-- No groupId, no version, no properties, no parent -->
<project>
  <modelVersion>4.0.0</modelVersion>
  <artifactId>bom</artifactId>
  <packaging>pom</packaging>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>junit</groupId>
        <artifactId>junit</artifactId>
        <version>${junit.version}</version>   <!-- unresolvable! -->
      </dependency>
    </dependencies>
  </dependencyManagement>
</project>

Scope of breakage

This affects virtually all real-world BOMs on the default (no-flatten) code path:

Root cause

The buildBomWithoutFlatten() method (introduced in #11427) was modeled after buildPom() which also uses getRawModel(). But transformPom() preserves the parent reference and properties (so consumers can resolve ${...} by reading the parent), while transformBom() strips them (BOMs are self-contained). Using getRawModel() with a parent-stripping transform is fundamentally incompatible.

Fix

• Route all BOMs through buildBom() which uses getEffectiveModel() (fully interpolated)
• Delete the now-dead buildBomWithoutFlatten() method

The flatten flag has no semantic effect on BOMs because transformBom() always strips parent and properties to produce a self-contained POM, regardless of the flag. The distinction only matters for regular POM packaging (where no-flatten preserves the parent reference).

Before → After

Test plan

• New IT MavenITBomConsumerPomPropertyResolutionTest with 3 test methods:
  • testBomConsumerPomResolvesParentProperties — default (no-flatten) path
  • testBomConsumerPomWithFlattenResolvesParentProperties — flatten=true path
  • testConsumerPomInProjectLocalRepo — verifies the -consumer.pom artifact
• All 4 existing BOM ITs pass (no regressions):
  • MavenITgh11427BomConsumerPomTest (2 tests)
  • MavenITConsumerPomBomFromSettingsRepoTest (1 test)
  • MavenITmng8293BomImportFromReactor (1 test)

🤖 Generated with Claude Code